Remove OC_App:installApp #4867
Merged
Remove OC_App:installApp #4867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* uses Installer->installApp now * removes unused code * fixes #4453 * added some additional checks Signed-off-by: Morris Jobke <[email protected]>
MorrisJobke
requested review from
LukasReschke,
blizzz,
nickvergessen and
rullzer
|
@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @LukasReschke and @georgehrke to be potential reviewers. |
icewind1991
approved these changes
May 15, 2017
LukasReschke
added a commit
that referenced
this pull request
May 15, 2017
OC_Group has been removed in March with #4867, the check in question is also performed two lines below already. Signed-off-by: Lukas Reschke <[email protected]>
Merged
LukasReschke
approved these changes
May 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested bundle install, app store install, normal install, a complete fresh server install. All worked, but I would like to ask you to have an in detail look at this change set.
The added stuff to
Installer::installAppis basically all the stuff that was done inOC_App::installAppand somehow makes sense to be executed. All the removals inOC_App::enableare now down in theInstaller::installAppand not needed there anymore.I couldn't find any place where
settings/ajax/installapp.phpwas used, so I deleted it. This and theenablemethod are the only places where the old method was called.